Using different active and owner keys #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaroncox
approved these changes
Dec 4, 2024
packages/snap/src/lib/keyDeriver.ts
Outdated
| chain: ChainDefinition, | ||
| keyIndex = 1, | ||
| ): Promise<PrivateKey> { | ||
| if (keyIndex === 0) { |
There was a problem hiding this comment.
I don't think this is a strong enough check.
If I pass in keyIndex = undefined to this function, the value won't be equal to 0 - so it'll bypass this and then pass undefined to derivePrivateKey, which will default to 0 and return the owner key.
Maybe we need to write it like this:
if (Number(keyIndex) > 0) {
return derivePrivateKey(chain, keyIndex);
}
throw new Error('Invalid key index');We just need to make sure there's no way to access index 0 from this call.
There was a problem hiding this comment.
if you pass undefined then the default 1 will be used 😄
There was a problem hiding this comment.
If you want, I'll change the default of derivePrivateKey to 1 so the owner key is never returned by default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.