Drop support for package_errors.log + EXIT_ON_MISSING_PACKAGES #304
+0
−140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was unreliable already within FAI, esp. when aborting and rerunning a build. Now with the switch from FAI to our minifai, we no longer support EXIT_ON_MISSING_PACKAGES. Minifai operates per class and aborts on any package installation that fails. There's no point in generating package_errors.log and TEST-MissingPackages.xml (meant for inclusion in e.g. Jenkins jobs), so drop config/scripts/GRMLBASE/01-packages overall, and related code from grml-live and setting in etc/grml/grml-live.conf. While at it, drop unused $VERBOSE, as complained by shellcheck. Closes: #295
zeha
approved these changes
Jan 30, 2025
mika
force-pushed
the
mika/package_errors
branch
from
1d7072f to
ca86de6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was unreliable already within FAI, esp. when aborting and rerunning a build.
Now with the switch from FAI to our minifai, we no longer support EXIT_ON_MISSING_PACKAGES. Minifai operates per class and aborts on any package installation that fails. There's no point in generating package_errors.log and TEST-MissingPackages.xml (meant for inclusion in e.g. Jenkins jobs), so drop config/scripts/GRMLBASE/01-packages overall, and related code from grml-live and setting in etc/grml/grml-live.conf.
Closes: #295