-
-
Notifications
You must be signed in to change notification settings - Fork 727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add privacy manifest file #1496
Conversation
Hello @danielepantaleone. It's nice to see you again, and thank your for presenting this welcome contribution for what it is. Would you please add the manifest to GRDBCustom.xcodeproj as well, as mentioned in the checklist? I'll check the PR after that. |
Sure, I'll add it as soon as I can 😊 |
Thanks @danielepantaleone, I'll review shortly. |
This technique has CocoaPods overwrite the app and other pods's manifest file and is not correct. Currently, there's no CocoaPods support for privacy manifest unless I'm mistaken: CocoaPods/CocoaPods#11990 And we can't publish new GRDB version on CocoaPods anyway: CocoaPods/CocoaPods#11839
OK @danielepantaleone. I amended your pull request:
I'm waiting for the CI to complete, and I should be able to merge next after. |
Thank you @danielepantaleone, the privacy manifest has shipped in v6.25.0 👍 |
Thanks! I didn't know that Cocoapods doesn't support the Privacy manifest. I did some research on StackOverflow to understand how to add resource files to a podspec, which is the reason why I added the file in the "resources" variable of the podspec. Thanks again for shipping the new version though 😃 |
Yes, I understand. I have a workspace that integrates GRDB with CocoaPods and I could inspect the application bundle and see that our privacy manifest was copied at the root of the bundle, which is not correct. Anyway, the landscape has changed since you have opened #1479 and I mentioned that CocoaPods support was desired: I can no longer publish a new version on CocoaPods anyway 😅 (CocoaPods/CocoaPods#11839). I hope this new version will remove any problem with GRDB at your workplace. |
This PR adds an empty Privacy Manifest file. Although a Privacy Manifest may be not needed for GRDB since no privacy sensitive API is used within the library, as mentioned already in #1480, adding an empty one doesn't compromise library functionalities in any way.
This solves #1479 and #1489.
Pull Request Checklist
development
branch.make smokeTest
terminal command runs without failure.