fix multiple circular logs

growthbook · Jun 21, 2024 · 819e5e1 · 819e5e1
1 parent 81b9295
commit 819e5e1
Showing 1 changed file with 8 additions and 4 deletions.
diff --git a/lib/src/main/java/growthbook/sdk/java/FeatureEvaluator.java b/lib/src/main/java/growthbook/sdk/java/FeatureEvaluator.java
@@ -34,8 +34,6 @@ public <ValueType> FeatureResult<ValueType> evaluateFeature(
             Class<ValueType> valueTypeClass,
             JsonObject attributeOverrides
     ) throws ClassCastException {
-        featureEvalContext.setId(key);
-
         // This callback serves for listening for feature usage events
         FeatureUsageCallback featureUsageCallback = context.getFeatureUsageCallback();
 
@@ -46,9 +44,14 @@ public <ValueType> FeatureResult<ValueType> evaluateFeature(
                 .build();
 
         try {
-            // block that handle recursion
-            log.info("evaluateFeature: circular dependency detected:");
             if (featureEvalContext.getEvaluatedFeatures().contains(key)) {
+                // block that handle recursion
+                log.info(
+                        "evaluateFeature: circular dependency detected: {} -> {}. { from: {}, to: {} }",
+                        featureEvalContext.getId(), key,
+                        featureEvalContext.getId(), key
+                );
+
                 FeatureResult<ValueType> featureResultWhenCircularDependencyDetected = FeatureResult
                         .<ValueType>builder()
                         .value(null)
@@ -62,6 +65,7 @@ public <ValueType> FeatureResult<ValueType> evaluateFeature(
             }
 
             featureEvalContext.getEvaluatedFeatures().add(key);
+            featureEvalContext.setId(key);
 
             // Check for feature values forced by URL
             if (context.getAllowUrlOverride()) {