Release #54
Merged
Release #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
vazarkevych
commented
May 11, 2024
vazarkevych
commented
- Changelog v0.5.1 v0.5.2 (Changelog v0.5.1 v0.5.2 #53)
Co-authored-by: Bohdan Akimenko <[email protected]>
* reduce amount of exceptions based on serialized null values and add break statements for most of the switch-cases. * add new test cases and ensure that unexpected exceptions let the tests fail. * trial commit * undo trial commit * Add attributeDataType checking for NULL. * adjust test definition and evaluation implementation. --------- Co-authored-by: Bohdan Akimenko <[email protected]>
Co-authored-by: Bohdan Akimenko <[email protected]>
Co-authored-by: Bohdan Akimenko <[email protected]>
…#46) * Add check & unit tests in case the feature value is a collection implementation (set, list) * Fixing errors after merge * Fixing failing test raised by merge --------- Co-authored-by: vu-linh <[email protected]> Co-authored-by: Bohdan Akimenko <[email protected]>
|
I have one question in regard of this line:
in |
| .minBucketVersion(rule.getMinBucketVersion()) | ||
| .bucketVersion(rule.getBucketVersion()) | ||
| .disableStickyBucketing(rule.getDisableStickyBucketing()) | ||
| .fallbackAttribute(rule.getFallbackAttribute()) |
There was a problem hiding this comment.
Should'nt we also set the ConditionalJson here?
There was a problem hiding this comment.
Thank you for mentioning this issue. We have fixed it and are now creating a new pull request with these changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.