core: added changes to make service config more explicit by logging required info #11917
+70
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shivaspeaks
added
the
kokoro:run
grpc-kokoro
removed
the
kokoro:run
shivaspeaks
reviewed
Mar 3, 2025
| InternalConfigSelector prevConfig = configSelector.get(); | ||
| configSelector.set(config); | ||
| configSelector.set(newConfig); | ||
| channelLogger.log(ChannelLogLevel.INFO, |
There was a problem hiding this comment.
This could be right but this can also lead to spamming as config update can happen per RPC.
Perhaps we should discuss/ rethink on the requirement for this logging. Or maybe it will be better if we log only when default config is applied and expected retry config is not applied when retry is enabled and service config is present. And we also need to figure out how it will help the user, about why the given config was not applied! Logging that will be much better.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
core: added changes to make service config more explicit by logging required details of transported JSON
Fixes: #5758