Refactor commercial boot process

[emma-imber]

What does this change?

Splits out the loadModules, recordCommercialMetrics and bootCommercial functions into a separate init-utils file for tidiness. Also splits consented.ts into two files - ad-free.ts and consented-advertising.ts. This (in my opinion) makes the ad free logic easier to find and clearer to read. By doing this, we also get rid of the idea of "base" and "extra" modules, which were confusingly named.

Why?

Having explained this code several times over the last few weeks to different people, I have noticed a few parts that don't make immediate sense when you try to explain them (eg the naming of base vs extra modules). I think this little refactor is much more readable, and focuses the different bundle entry point files on the modules that they load.

Also, by having an ad-free specific file, we should be shipping less code to end users who don't see ads. I am also in favour of having the ad free check in the commercial file instead of the consented file, as I think it makes the purpose of each file much clearer to understand.

Would like to hear other people's thoughts on if this is an improvement or not!

[changeset-bot]

⚠️ No Changeset found

Latest commit: 89534d2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[github-actions]

Deploy build 3027 of dotcom::commercial-bundle to CODE

All deployment options

• Deploy build 3027 of dotcom::commercial-bundle to CODE
• Deploy parts of build 3027 to CODE by previewing it first
• What's on CODE right now?

---

From guardian/actions-riff-raff.

[github-actions]

Ad load time test results

For consented, top-above-nav took on average 4321ms to load.
For consentless, top-above-nav took on average 3077ms to load.

Test conditions:

• 5mbps download speed
• 1.5mbps upload speed
• 150ms latency