Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade elasticsearch SDK to version 8.11 #187

Merged
merged 5 commits into from
Jan 9, 2024
Merged

Conversation

philmcmahon
Copy link
Contributor

@philmcmahon philmcmahon commented Dec 18, 2023

What does this change?

(Draft PR pending upgrade to ES8)

Following from #190 This PR drags giant's elasticsearch code into the future, ready to support elasticsearch 8.

Key changes:

How to test

Tested locally and on playground. Make sure you have run #190 (now merged into main) locally before trying this as you need your local DB to already be on 7.17 to work

Deploying on PROD:

HOWEVER, we appear to be succesfully running sdk 7.17 against elasticsearch 8 on playground, so maybe we don't need compatability mode

@philmcmahon philmcmahon changed the base branch from main to pm-upgrade-es-sdk-717 January 3, 2024 14:10
@philmcmahon philmcmahon changed the base branch from pm-upgrade-es-sdk-717 to main January 3, 2024 14:11
@philmcmahon philmcmahon marked this pull request as ready for review January 8, 2024 12:51
@philmcmahon philmcmahon requested a review from a team as a code owner January 8, 2024 12:51
Copy link
Contributor

@marjisound marjisound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@marjisound marjisound merged commit 185bb80 into main Jan 9, 2024
1 check passed
@marjisound marjisound deleted the upgrade-es-sdk branch January 9, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants