-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation for providers #3154
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AWare
reviewed
Feb 2, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thorough
AWare
approved these changes
Feb 2, 2021
paperboyo
reviewed
Feb 2, 2021
paperboyo
reviewed
Feb 2, 2021
paperboyo
reviewed
Feb 2, 2021
paperboyo
reviewed
Feb 2, 2021
paperboyo
reviewed
Feb 2, 2021
paperboyo
reviewed
Feb 2, 2021
paperboyo
reviewed
Feb 2, 2021
paperboyo
reviewed
Feb 2, 2021
paperboyo
reviewed
Feb 2, 2021
paperboyo
reviewed
Feb 2, 2021
sihil
force-pushed
the
sihil/plugin-documentation
branch
from
February 3, 2021 11:05
ad5b995
to
d8e4f1d
Compare
Seen on auth, usage, cropper, collections, media-api, kahuna, image-loader, image-loader-projection, metadata-editor, leases (merged by @sihil 9 minutes and 42 seconds ago) Please check your changes! |
prout-bot
added
Seen-on-auth
Seen-on-collections
Seen-on-cropper
Seen-on-image-loader
Seen-on-image-loader-projection
Seen-on-kahuna
Seen-on-leases
Seen-on-media-api
Seen-on-metadata-editor
Seen-on-usage
and removed
Pending-on-cropper
Pending-on-image-loader
Pending-on-image-loader-projection
Pending-on-kahuna
Pending-on-leases
Pending-on-media-api
Pending-on-metadata-editor
Pending-on-usage
labels
Feb 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Until now we did not have any documentation to tell users how we expect them to implement and use providers for ImageProcessors (#3004) and AuthenticationProviders (#3058). This was a follow on action from discussion when #3058 was being reviewed.
There is probably room for improvement here but this should be a helpful starting point. I'd recommend that you review this by reading the rendered markdown!
Closes #3103.
How can success be measured?
Organisations picking up the grid have some starting points for extending the processing pipelines and auth systems.
Who should look at this?
@guardian/digital-cms
Tested?
n/a