Commit mass-deletion script #3959
Conversation
|
|
||
| del=todelete.txt | ||
| prog=progress.txt | ||
| com="complete.txt" |
There was a problem hiding this comment.
if this value is quoted, does that mean the others should be too?
There was a problem hiding this comment.
there's no spaces in the values so all are optional for quoting. I've removed the quotes from complete for consistency
| ndone=$((ndone + 1)) | ||
| if [[ $skipping = 1 && -n "$last" && $id != $last ]]; then | ||
| continue | ||
| elif [[ $skipping = 1 && -n "$last" ]]; then |
There was a problem hiding this comment.
it took me a minute to work out why skipping was initially set to 1. I take it that it's because we're looking through the ids until we find the first one after the 'prog' value (if there's one set) and only then do we start processing them? this seems v sensible but might benefit from a brief comment to explain the pattern?
andrew-nowak
force-pushed
the
an/mass-deletion-script
branch
from
1c47700 to
1bcc139
Compare
prout-bot
added
Pending-on-cropper
Pending-on-leases
Pending-on-media-api
Pending-on-image-loader
Pending-on-metadata-editor
Pending-on-collections
Pending-on-usage
Pending-on-kahuna
Pending-on-auth
Pending-on-thrall
Seen-on-image-loader
Seen-on-cropper
and removed
Pending-on-cropper
Pending-on-image-loader
labels
|
Seen on image-loader, cropper (merged by @andrew-nowak 7 minutes and 34 seconds ago) Please check your changes! |
prout-bot
added
Seen-on-kahuna
and removed
Pending-on-metadata-editor
Pending-on-kahuna
labels
|
Seen on metadata-editor, kahuna (merged by @andrew-nowak 7 minutes and 45 seconds ago) Please check your changes! |
|
Seen on leases (merged by @andrew-nowak 7 minutes and 49 seconds ago) Please check your changes! |
|
Seen on collections, media-api (merged by @andrew-nowak 7 minutes and 58 seconds ago) Please check your changes! |
|
Seen on collections (merged by @andrew-nowak 7 minutes and 58 seconds ago) Please check your changes! |
|
Seen on media-api (merged by @andrew-nowak 7 minutes and 59 seconds ago) Please check your changes! |
|
Seen on collections (merged by @andrew-nowak 8 minutes and 2 seconds ago) Please check your changes! |
|
Seen on usage (merged by @andrew-nowak 8 minutes and 15 seconds ago) Please check your changes! |
|
Seen on thrall (merged by @andrew-nowak 8 minutes and 19 seconds ago) Please check your changes! |
|
Seen on auth (merged by @andrew-nowak 8 minutes and 27 seconds ago) Please check your changes! |
What does this change?
Store the mass deletion script in repo for reuse and an example of how to create and run mass operation scripts.
How should a reviewer test this change?
Does the README make sense? Is the script easy to understand