upgrade v2 kcl #4383
Merged
upgrade v2 kcl #4383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twrichards
approved these changes
Dec 17, 2024
|
Seen on cropper (merged by @andrew-nowak 7 minutes and 36 seconds ago) Please check your changes! |
prout-bot
added
Seen-on-auth
Seen-on-kahuna
and removed
Pending-on-collections
Pending-on-kahuna
Pending-on-auth
labels
|
Seen on auth, collections, kahuna (merged by @andrew-nowak 7 minutes and 45 seconds ago) Please check your changes! |
prout-bot
added
Seen-on-collections
and removed
Pending-on-leases
Pending-on-media-api
labels
prout-bot
added
Seen-on-leases
Seen-on-image-loader
Seen-on-media-api
and removed
Pending-on-image-loader
labels
|
Seen on image-loader, leases, media-api (merged by @andrew-nowak 7 minutes and 52 seconds ago) Please check your changes! |
|
Seen on usage (merged by @andrew-nowak 7 minutes and 56 seconds ago) Please check your changes! |
|
Seen on thrall (merged by @andrew-nowak 8 minutes and 2 seconds ago) Please check your changes! |
|
Seen on metadata-editor (merged by @andrew-nowak 8 minutes and 6 seconds ago) Please check your changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
The kinesis-client-library brings in a series of transitive dependencies with high vulnerability warnings. Upgrade to the latest in the v2 series to remove as many as possible with straightforward upgrades.
Further upgrades will be required in the near future, but we should follow the migration steps here https://docs.aws.amazon.com/streams/latest/dev/kcl-migration-from-2-3.html
How should a reviewer test this change?
Deploy to TEST, and upload or edit an image - check that the updates flow through the update stream to thrall and are persisted into the ES cluster.
How can success be measured?
Who should look at this?
Tested? Documented?