Play v3 migration #4402
Merged
Play v3 migration #4402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryophyta
approved these changes
Jan 21, 2025
prout-bot
added
Pending-on-cropper
Pending-on-leases
Pending-on-media-api
Pending-on-image-loader
Pending-on-metadata-editor
Pending-on-collections
Pending-on-usage
Pending-on-kahuna
Pending-on-auth
Pending-on-thrall
Seen-on-auth
Seen-on-leases
and removed
Pending-on-leases
Pending-on-metadata-editor
Pending-on-collections
Pending-on-usage
Pending-on-kahuna
Pending-on-auth
labels
|
Seen on auth, usage, metadata-editor, leases, collections, kahuna (merged by @andrew-nowak 9 minutes and 1 second ago) Please check your changes! |
|
Seen on thrall, media-api (merged by @andrew-nowak 9 minutes and 7 seconds ago) Please check your changes! |
|
Seen on cropper (merged by @andrew-nowak 9 minutes and 19 seconds ago) Please check your changes! |
|
Seen on image-loader (merged by @andrew-nowak 9 minutes and 24 seconds ago) Please check your changes! |
1 similar comment
|
Seen on image-loader (merged by @andrew-nowak 9 minutes and 24 seconds ago) Please check your changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Upgrades Grid to Play v3.
The main changes include Grid's move from Akka to Pekko, which involves updating import paths but otherwise behaviour should be the same. To accommodate the move, we also switch from kcl-akka-stream to kcl-pekko-stream, which likewise involves updated import paths but should otherwise behave the same.
How should a reviewer test this change?
Run locally or on the TEST environment, and see if the app continues to perform
How can success be measured?
Who should look at this?
Tested? Documented?