Run tests in CI

guardian · Mar 11, 2024 · a340321 · a340321
1 parent 4201eaa
commit a340321
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 16 deletions.
diff --git a/.github/workflows/ci-mobile-save-for-later-user-deletion.yaml b/.github/workflows/ci-mobile-save-for-later-user-deletion.yaml
@@ -20,6 +20,9 @@ jobs:
           distribution: temurin
           cache: sbt
 
+      - name: Run Tests
+        run: sbt "project mobile-save-for-later-user-deletion" test
+
       - name: Create artifacts
         run: sbt "project mobile-save-for-later-user-deletion" assembly
 

diff --git a/.github/workflows/ci-mobile-save-for-later.yaml b/.github/workflows/ci-mobile-save-for-later.yaml
@@ -20,6 +20,9 @@ jobs:
           distribution: corretto
           cache: sbt
 
+      - name: Run Tests
+        run: sbt "project mobile-save-for-later" test
+
       - name: Create artifacts
         run: sbt "project mobile-save-for-later" assembly
 

diff --git a/mobile-save-for-later/src/test/scala/com/gu/sfl/lib/ArticleMergeSpecification.scala b/mobile-save-for-later/src/test/scala/com/gu/sfl/lib/ArticleMergeSpecification.scala
@@ -91,10 +91,6 @@ class ArticleMergeSpecification extends Specification with Mockito {
       val saved =
         savedArticlesMerger.updateWithRetryAndMerge(userId, savedArticles2)
       there was one(savedArticlesPersistence).read(argThat(===(userId)))
-      there were no(savedArticlesPersistence).write(
-        any[String](),
-        any[SavedArticles]()
-      )
       there was one(savedArticlesPersistence).update(
         argThat(===(userId)),
         argThat(===(savedArticles2))
@@ -110,10 +106,6 @@ class ArticleMergeSpecification extends Specification with Mockito {
       val saved =
         savedArticlesMerger.updateWithRetryAndMerge(userId, savedArticles)
       there was one(savedArticlesPersistence).read(argThat(===(userId)))
-      there were no(savedArticlesPersistence).write(
-        any[String](),
-        any[SavedArticles]()
-      )
       there were no(savedArticlesPersistence).update(
         any[String](),
         any[SavedArticles]()
@@ -185,10 +177,6 @@ class ArticleMergeSpecification extends Specification with Mockito {
       val saved =
         savedArticlesMerger.updateWithRetryAndMerge(userId, savedArticles2)
 
-      there were no(savedArticlesPersistence).write(
-        any[String](),
-        any[SavedArticles]()
-      )
       there was one(savedArticlesPersistence).update(
         argThat(===(userId)),
         argThat(===(expectedArticlesPersisted))
@@ -222,10 +210,6 @@ class ArticleMergeSpecification extends Specification with Mockito {
       ) returns (Success(Some(expectedArticlesPersisted.advanceVersion)))
       val saved =
         savedArticlesMerger.updateWithRetryAndMerge(userId, articlesToSave)
-      there were no(savedArticlesPersistence).write(
-        any[String](),
-        any[SavedArticles]()
-      )
       there was one(savedArticlesPersistence).update(
         argThat(===(userId)),
         argThat(===(expectedArticlesPersisted))