Move the implicit val to the companion object

guardian · Feb 28, 2024 · a9045e0 · a9045e0
1 parent 2046e24
commit a9045e0
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 11 deletions.
diff --git a/common/src/main/scala/com/gu/sfl/persistence/SavedArticlesPersistence.scala b/common/src/main/scala/com/gu/sfl/persistence/SavedArticlesPersistence.scala
@@ -34,6 +34,12 @@ case class DynamoSavedArticles(
 )
 
 object DynamoSavedArticles {
+  implicit val formatcom: DynamoFormat[com.gu.sfl.persistence.DynamoSavedArticles] = new DynamoFormat[DynamoSavedArticles] {
+    override def read(av: DynamoValue): Either[DynamoReadError, DynamoSavedArticles] = Right(DynamoSavedArticles("uasd", SavedArticles("asd", Nil)))
+
+    override def write(t: DynamoSavedArticles): DynamoValue = DynamoValue.fromString("")
+  }
+
   def apply(userId: String, savedArticles: SavedArticles): DynamoSavedArticles =
     DynamoSavedArticles(
       userId,
@@ -59,13 +65,7 @@ class SavedArticlesPersistenceImpl(persistanceConfig: PersistenceConfig)
   private val scanamo = Scanamo(client)
 
   import org.scanamo.syntax._
-  import org.scanamo.generic.auto._
 
-  implicit val formatcom: DynamoFormat[com.gu.sfl.persistence.DynamoSavedArticles]= new DynamoFormat[DynamoSavedArticles] {
-    override def read(av: DynamoValue): Either[DynamoReadError, DynamoSavedArticles] = Right(DynamoSavedArticles("uasd", SavedArticles("asd", Nil)))
-
-    override def write(t: DynamoSavedArticles): DynamoValue = DynamoValue.fromString("")
-  }
 
   val table = Table[DynamoSavedArticles](persistanceConfig.tableName)
 

diff --git a/...save-for-later-user-deletion/src/main/scala/coml/gu/sfl/userdeletion/db/SflDynamoDb.scala b/...save-for-later-user-deletion/src/main/scala/coml/gu/sfl/userdeletion/db/SflDynamoDb.scala
@@ -9,11 +9,6 @@ import com.gu.sfl.persistence.{DynamoSavedArticles, PersistenceConfig}
 import com.gu.sfl.userdeletion.model.UserDeleteMessage
 
 class SflDynamoDb(persistanceConfig: PersistenceConfig) extends Logging {
-  implicit val formatcom: DynamoFormat[com.gu.sfl.persistence.DynamoSavedArticles] = new DynamoFormat[DynamoSavedArticles] {
-    override def read(av: DynamoValue): Either[DynamoReadError, DynamoSavedArticles] = Right(DynamoSavedArticles("uasd", SavedArticles("asd", Nil)))
-
-    override def write(t: DynamoSavedArticles): DynamoValue = DynamoValue.fromString("")
-  }
 
   private val table = Table[DynamoSavedArticles](persistanceConfig.tableName)
   private val client = DynamoDbClient.builder().build()