Use update instead of write

guardian · Mar 20, 2024 · b044803 · b044803
1 parent f7838c2
commit b044803
Show file tree

Hide file tree

Showing 3 changed files with 209 additions and 103 deletions.
diff --git a/common/src/main/scala/com/gu/sfl/persistence/SavedArticlesPersistence.scala b/common/src/main/scala/com/gu/sfl/persistence/SavedArticlesPersistence.scala
@@ -29,11 +29,6 @@ trait SavedArticlesPersistence {
       userId: String,
       savedArticles: SavedArticles
   ): Try[Option[SavedArticles]]
-
-  def write(
-      userId: String,
-      savedArticles: SavedArticles
-  ): Try[Option[SavedArticles]]
 }
 
 case class DynamoSavedArticles(
@@ -119,32 +114,6 @@ class SavedArticlesPersistenceImpl(persistanceConfig: PersistenceConfig)
     }
   }
 
-  override def write(
-      userId: String,
-      savedArticles: SavedArticles
-  ): Try[Option[SavedArticles]] = {
-    scanamo.exec(
-      table.putAndReturn(PutReturn.OldValue)(
-        DynamoSavedArticles(userId, savedArticles)
-      )
-    ) match {
-      case Some(Right(articles)) =>
-        logger.debug(s"Succcesfully saved articles for $userId")
-        Success(Some(articles.ordered))
-      case Some(Left(error)) =>
-        val exception = new IllegalArgumentException(s"$error")
-        logger.error(
-          s"Exception Thrown saving articles for $userId:",
-          exception
-        )
-        Failure(exception)
-      case None => {
-        logger.debug(s"Successfully saved but none retrieved for $userId")
-        Success(Some(savedArticles))
-      }
-    }
-  }
-
   override def update(
       userId: String,
       savedArticles: SavedArticles