Use simple logger #112
Merged
Use simple logger #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, just out of curiority, why are the "simplelogger.properties" empty? Default settings are sufficient for us? |
Yeah, the default settings is to log at the level INFO: https://www.slf4j.org/api/org/slf4j/simple/SimpleLogger.html I think that is fine for our use-case |
aracho1
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
This changes the library we use to produce the logs from Log4J to Simple Logger. This is because upgrading the Java version introduced a breaking change to the current logging config, which meant that log levels at debug was being outputted to Cloudwatch. After following the docs and this example, the app was still sending docs at Debug level.
Our use-case for logging can be fairly lightweight, and it turned out to be straightforward to configure the Simple Logger.
How to test
How can we measure success?
Have we considered potential risks?
Images
Accessibility