Newswires UI: add pagination #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sb-dev
force-pushed
the
ui-add-pagination
branch
4 times, most recently
from
9f268bf to
3fad1a0
Compare
sb-dev
force-pushed
the
ui-add-pagination
branch
from
3fad1a0 to
54a1357
Compare
sb-dev
force-pushed
the
ui-add-pagination
branch
from
54a1357 to
6b19f70
Compare
bryophyta
reviewed
Jan 24, 2025
| @@ -167,15 +180,34 @@ export function SearchContextProvider({ children }: PropsWithChildren) { | |||
| }); | |||
| } | |||
|
|
|||
| if (state.status === 'success' || state.status === 'offline') { | |||
| if (state.status === 'loading-more') { | |||
| fetchResults(currentConfig.query, { | |||
There was a problem hiding this comment.
I wonder whether it would be more straightforward to put the fetch().then().catch() into the body of the loadMoreResults function? It will hopefully keep the number of branches in the status state machine simpler, and as far as I can tell it's only the load more button itself that needs to know about whether the fetch is underway, so we could perhaps have 'loading-more' as a piece of more local state. What do you think?
sb-dev
force-pushed
the
ui-add-pagination
branch
2 times, most recently
from
b856e3d to
7f1c1e0
Compare
sb-dev
force-pushed
the
ui-add-pagination
branch
3 times, most recently
from
2aec945 to
a5c5ad9
Compare
bryophyta
reviewed
Jan 24, 2025
bryophyta
reviewed
Jan 24, 2025
bryophyta
approved these changes
Jan 24, 2025
sb-dev
force-pushed
the
ui-add-pagination
branch
from
a5c5ad9 to
0fe356d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Add a load more button to view older stories.
How to test
How can we measure success?
Have we considered potential risks?
Images
Accessibility