-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use anchor tags for feed #110
Conversation
14ddcba
to
0241b75
Compare
re-implements some of #81 |
@@ -273,6 +280,32 @@ export function SearchContextProvider({ children }: PropsWithChildren) { | |||
dispatch({ type: 'TOGGLE_AUTO_UPDATE' }); | |||
}; | |||
|
|||
const Link = ({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be worth moving the Link component to it's own file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
currently it's defined within the scope of SearchContext
because it needs to access pushConfigState
, so if we pulled it out to a separate file we'd need to pass the push
function as an argument when constructing the Link component.
Given that we don't currently have a need for multiple Link components with different push
functions, I'm inclined to leave it defined inside SearchContext
-- what do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can to use handleSelectItem
to update the config state?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
feels like this point is worth a synchronous chat? I'll send you an invite 👍
641ffdc
to
c29af33
Compare
What does this change?
The main change is to refactor the feed view so that it uses a list of links (
<a>
tags) instead of a table:cmd+click
behaviour etc.Additional changes:
<EuiBadge>
to display supplier info, rather than including it at the end of the headline/slug.How to test
How can we measure success?
Have we considered potential risks?
Images
Before and after
Accessibility