Cleanup Lambda: add scheduled cleanup lambda #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sb-dev
commented
Jan 29, 2025
sb-dev
force-pushed
the
add-cleanup-lambda
branch
2 times, most recently
from
b43d481 to
98d7354
Compare
sb-dev
force-pushed
the
add-cleanup-lambda
branch
from
98d7354 to
e434cdf
Compare
bryophyta
reviewed
Jan 30, 2025
| architecture: LAMBDA_ARCHITECTURE, | ||
| handler: 'handler.main', | ||
| fileName: 'cleanup-lambda.zip', | ||
| timeout: Duration.millis(45000), |
There was a problem hiding this comment.
what's the reason for this timeout? My instinct is to go for a longer timeout as it's a batch job.. Have we done any tests to see how long it would usually take to complete?
There was a problem hiding this comment.
I haven't done any test yet; the 45s timeout is just a place holder while waiting to figure a better value for it.
bryophyta
reviewed
Jan 30, 2025
|
|
||
| console.log(`Deleted ${result.count} records`); | ||
| } catch (error) { | ||
| console.error('Error deleting old records:', error); |
There was a problem hiding this comment.
might we want to fail the job in this case, so that we can add retry behaviour? (this could wait for a separate PR though)
sb-dev
force-pushed
the
add-cleanup-lambda
branch
from
eb65cc8 to
2d57399
Compare
sb-dev
force-pushed
the
add-cleanup-lambda
branch
from
2d57399 to
36743d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Add a scheduled cleanup lambda to delete stories older than 2 weeks.
Scheduled to run every day at 5am.
How to test
How can we measure success?
Have we considered potential risks?
Images
Accessibility