Merge pull request #300 from guardian/avatar-URL-discrepancies

remove avatar URL discrepancy detection (since it's arguably more wasteful than just updating the DB records)
guardian · Dec 18, 2023 · 04e9003 · 04e9003
2 parents 61775e6 + a5370da
commit 04e9003
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 37 deletions.
diff --git a/users-refresher-lambda/src/google/isDefinitelyDifferentAvatar.ts b/users-refresher-lambda/src/google/isDefinitelyDifferentAvatar.ts
diff --git a/users-refresher-lambda/src/index.ts b/users-refresher-lambda/src/index.ts
@@ -19,7 +19,6 @@ import {
 import { buildUserLookupFromDatabase } from "./google/buildUserLookupFromDatabase";
 import { getGroupMembersFromGoogle } from "./google/getGroupMembersFromGoogle";
 import { getGroupDetailFromGoogle } from "./google/getGroupDetailFromGoogle";
-import { isDefinitelyDifferentAvatar } from "./google/isDefinitelyDifferentAvatar";
 
 const s3 = new S3(standardAwsConfig);
 
@@ -146,11 +145,7 @@ export const handler = async ({
           maybeUserFromDatabase.firstName !== maybeUserFromGoogle.firstName ||
           maybeUserFromDatabase.lastName !== maybeUserFromGoogle.lastName ||
           maybeUserFromDatabase.googleID !== maybeUserFromGoogle.googleID ||
-          (await isDefinitelyDifferentAvatar(
-            email,
-            maybeUserFromDatabase.avatarUrl,
-            maybeAvatarUrl
-          ))
+          maybeUserFromDatabase.avatarUrl !== maybeAvatarUrl // annoyingly these URLs often differ despite the image not changing - thanks Google!!
         ) {
           console.log(`Updating details for user ${email}`);
           await sql`