make Stage part of the metricNamespace for the email-lambda race …

…condition metric, rather than use a dimension since dimensions aren't supported (fails at cloudforming)
guardian · Nov 29, 2024 · ac464db · ac464db
1 parent 214e1b8
commit ac464db
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 12 deletions.
diff --git a/cdk/lib/__snapshots__/stack.test.ts.snap b/cdk/lib/__snapshots__/stack.test.ts.snap
@@ -1587,7 +1587,7 @@ Object {
         "ComparisonOperator": "GreaterThanOrEqualToThreshold",
         "EvaluationPeriods": 1,
         "MetricName": "EmailLambdaRaceCondition",
-        "Namespace": "Pinboard",
+        "Namespace": "Pinboard/TEST",
         "Period": 300,
         "Statistic": "Average",
         "Tags": Array [
@@ -1632,14 +1632,8 @@ Object {
         },
         "MetricTransformations": Array [
           Object {
-            "Dimensions": Array [
-              Object {
-                "Key": "Stage",
-                "Value": "TEST",
-              },
-            ],
             "MetricName": "EmailLambdaRaceCondition",
-            "MetricNamespace": "Pinboard",
+            "MetricNamespace": "Pinboard/TEST",
             "MetricValue": "1",
           },
         ],

diff --git a/cdk/lib/stack.ts b/cdk/lib/stack.ts
@@ -654,10 +654,7 @@ export class PinBoardStack extends GuStack {
           `/aws/lambda/${emailLambda.functionName}`
         ),
         metricName: "EmailLambdaRaceCondition",
-        metricNamespace: "Pinboard",
-        dimensions: {
-          Stage: this.stage,
-        },
+        metricNamespace: `Pinboard/${this.stage}`,
         filterPattern: {
           logPatternString: EMAIL_LAMBDA_RACE_CONDITION_LOG_LINE_SNIPPET,
         },