Update RDS database cdk #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobwinch
reviewed
Jan 26, 2024
| @@ -593,6 +593,7 @@ Object { | |||
| "DBSubnetGroupName": Object { | |||
| "Ref": "DatabaseSubnetGroup7D60F180", | |||
| }, | |||
| "DeleteAutomatedBackups": false, | |||
| "DeletionProtection": true, | |||
There was a problem hiding this comment.
Interesting that DeletionProtection was already true in the generated CFN prior to our change here - looks like it is already being set (by aws-cdk) due to:
removalPolicy: RemovalPolicy.RETAIN
There was a problem hiding this comment.
Interesting! I'd like to keep the 'deletionProtection' explicit though (i.e. this PR as-is)
twrichards
approved these changes
Jan 26, 2024
|
Seen on PROD (merged by @Georges-GNM 5 minutes and 22 seconds ago) Please check your changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Makes the config slightly safer by adding deleteProtection and enabling us to delete backups in a straightforward manner if needed.
How to test
This has been put on code, we could verify the cfn was appropriately updated.