get all tags in alarm handler rather than just App #2636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnduffell
commented
Jan 15, 2025
| @@ -94,6 +95,7 @@ describe('Handler', () => { | |||
| }); | |||
|
|
|||
| it('should throw error if the fetch HTTP call fails', async () => { | |||
| (getTags as jest.Mock).mockResolvedValueOnce({ App: 'mock-app' }); | |||
There was a problem hiding this comment.
I don't quite understand why we didn't need this line before.
For some reason the tests were failing to initialise with the mock Fetch error below, but no useful stack trace. I presume Promises can be a bit like scala Futures in that respect.
I guessed that getTags was the only other thing that could call fetch, and by mocking that it started working.
The strange thing was how did it work before? It definitely worked ok if I shelve the commit in this PR.
It was failing locally and also when I pushed.
This is one of the tests that does need to use a mocked fetch (as opposed to calling a pure function) as it's specifically testing what happens if it fails the http call.
There was a problem hiding this comment.
error was
/Users/john_duffell/code/support-service-lambdas/handlers/alarms-handler/test/index.test.ts:78
.mockResolvedValue(Promise.reject(new Error('Fetch error')));
^
Error: Fetch error
at Object.<anonymous> (/Users/john_duffell/code/support-service-lambdas/handlers/alarms-handler/test/index.test.ts:100:38)
at Promise.then.completed (/Users/john_duffell/code/support-service-lambdas/node_modules/.pnpm/[email protected]/node_modules/jest-circus/build/utils.js:298:28)
at new Promise (<anonymous>)
at callAsyncCircusFn (/Users/john_duffell/code/support-service-lambdas/node_modules/.pnpm/[email protected]/node_modules/jest-circus/build/utils.js:231:10)
at _callCircusTest (/Users/john_duffell/code/support-service-lambdas/node_modules/.pnpm/[email protected]/node_modules/jest-circus/build/run.js:316:40)
at processTicksAndRejections (node:internal/process/task_queues:95:5)
at _runTest (/Users/john_duffell/code/support-service-lambdas/node_modules/.pnpm/[email protected]/node_modules/jest-circus/build/run.js:252:3)
at _runTestsForDescribeBlock (/Users/john_duffell/code/support-service-lambdas/node_modules/.pnpm/[email protected]/node_modules/jest-circus/build/run.js:126:9)
at _runTestsForDescribeBlock (/Users/john_duffell/code/support-service-lambdas/node_modules/.pnpm/[email protected]/node_modules/jest-circus/build/run.js:121:9)
at run (/Users/john_duffell/code/support-service-lambdas/node_modules/.pnpm/[email protected]/node_modules/jest-circus/build/run.js:71:3)
at runAndTransformResultsToJestFormat (/Users/john_duffell/code/support-service-lambdas/node_modules/.pnpm/[email protected]/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapterInit.js:122:21)
at jestAdapter (/Users/john_duffell/code/support-service-lambdas/node_modules/.pnpm/[email protected]/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:79:19)
at runTestInternal (/Users/john_duffell/code/support-service-lambdas/node_modules/.pnpm/[email protected]/node_modules/jest-runner/build/runTest.js:367:16)
at runTest (/Users/john_duffell/code/support-service-lambdas/node_modules/.pnpm/[email protected]/node_modules/jest-runner/build/runTest.js:444:34)
at Object.worker (/Users/john_duffell/code/support-service-lambdas/node_modules/.pnpm/[email protected]/node_modules/jest-runner/build/testWorker.js:106:12)
Node.js v20.11.0
johnduffell
commented
Jan 15, 2025
| @@ -49,24 +49,24 @@ const buildCloudwatchClient = (awsAccountId: string): CloudWatchClient => { | |||
| return new CloudWatchClient({ region: 'eu-west-1' }); | |||
| }; | |||
|
|
|||
| const getTags = async ( | |||
| export type Tags = { | |||
| App?: string; | |||
There was a problem hiding this comment.
so far we only have App but the idea is to add a URL template for the logs link(s)
This was referenced Jan 15, 2025
# Conflicts: # handlers/alarms-handler/test/index.test.ts
tjmw
approved these changes
Jan 23, 2025
# Conflicts: # handlers/alarms-handler/src/index.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR follows on from #2635 and is the next part split out from the old PR #2487
In this PR I refactor the code that retrieves the tags on the alarm. Rather than just selecting the
Apptag, this returns an object containing all defined tags.This means that in the next PR we can look at a new tag to build a log URL.