Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support arbitrary urls for batch tagging #502

Merged
merged 1 commit into from
Nov 24, 2023
Merged

support arbitrary urls for batch tagging #502

merged 1 commit into from
Nov 24, 2023

Conversation

twrichards
Copy link
Contributor

@twrichards twrichards commented Nov 23, 2023 •
edited
Loading

CP were asked to batch tag 1091 web urls with a tag and so it made sense to add that feature to the existing 'batch tag' functionality already present (which worked based on CAPI searches and ticking items). Fortunately the existing batchTag operation took simply a list of paths so most of this PR is just UI - encapsulated in a new React component BatchTagArbitraryUrls.

batch_arbitrary

@twrichards twrichards force-pushed the batch-tag-arbitrary-urls branch 2 times, most recently from 25012b5 to a77a782 Compare November 23, 2023 21:30
@twrichards twrichards changed the title add button to prompt for arbitrary urls for batch tagging support arbitrary urls for batch tagging Nov 23, 2023
@twrichards twrichards marked this pull request as ready for review November 23, 2023 21:47
@twrichards twrichards force-pushed the batch-tag-arbitrary-urls branch 2 times, most recently from 4d4ba91 to f7dce4e Compare November 23, 2023 21:57
@rhystmills
Copy link
Contributor

rhystmills commented Nov 24, 2023 •
edited
Loading

Is it worth checking that each line is a valid URL before submitting them?
I tried adding a blank line into the pasted data and ended up with:
image
(So at least it fails in a controlled manner, but would be nice to spot this on submission.
We could map the cleaned data down to only valid urls - or at least remove empty strings.

@twrichards twrichards force-pushed the batch-tag-arbitrary-urls branch from f7dce4e to e549978 Compare November 24, 2023 09:58
@twrichards
Copy link
Contributor Author

Is it worth checking that each line is a valid URL before submitting them? I tried adding a blank line into the pasted data and ended up with: image (So at least it fails in a controlled manner, but would be nice to spot this on submission. We could map the cleaned data down to only valid urls - or at least remove empty strings.

good spot @rhystmills - I've made it filter out empty (deployed to CODE)

rhystmills
rhystmills approved these changes Nov 24, 2023
View reviewed changes
Copy link
Contributor

@rhystmills rhystmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, great to get a useful feature out so quickly!
Tested in CODE and working nicely.

@twrichards twrichards merged commit a5b0344 into main Nov 24, 2023
1 check passed
@twrichards twrichards deleted the batch-tag-arbitrary-urls branch November 24, 2023 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhystmills rhystmills rhystmills approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@twrichards @rhystmills