Deploy DynamoDB tables via Riff-Raff #503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobwinch
commented
Dec 1, 2023
| templatePath: pillar-dynamo.yaml | ||
| prependStackToCloudFormationStackName: false | ||
| cloudFormationStackName: pillars-dynamo | ||
| cloudFormationStackByTags: false |
There was a problem hiding this comment.
Generally I prefer tag based discovery, but this repo is already using stack name based discovery and I think it's better to remain consistent within the same repo
jacobwinch
force-pushed
the
jw-riff-raff-dynamo
branch
from
a20360e to
82e4446
Compare
jacobwinch
commented
Dec 1, 2023
| @@ -6,6 +6,8 @@ deployments: | |||
| type: autoscaling | |||
| dependencies: | |||
| - cloudformation | |||
| - cloudformation-pillar-db | |||
There was a problem hiding this comment.
We are going to deploy all 3 CFN stacks concurrently so it shouldn't slow down deployments too much
davidfurey
approved these changes
Dec 1, 2023
| templatePath: pillar-dynamo.yaml | ||
| prependStackToCloudFormationStackName: false | ||
| cloudFormationStackName: pillars-dynamo | ||
| cloudFormationStackByTags: false |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
This PR allows Riff-Raff to deploy
tag-manager's DynamoDB tables. These are currently deployed manually via separate CloudFormation stacks1.How to test
I've tested this by deploying to
CODEand confirming that Riff-Raff is updating the correct stacks.Note that the first deployment with Riff-Raff will update all resources in these separate stacks as Riff-Raff automatically adds some tags.
How can we measure success?
It will be possible to apply all AWS infrastructure changes for this app via Riff-Raff.
Have we considered potential risks?
Historically some teams were nervous about deploying databases using Riff-Raff, but we now have protections in place to avoid the accidental deletion of stateful resource types. We deploy many DynamoDB tables across the estate using Riff-Raff and in some respects this reduces risk by avoiding the need to manually update production resources via the AWS Console.
Footnotes
I think splitting this infrastructure across 3 separate CFN stacks is adding unnecessary complexity so it would be nice to combine them in the future. However, that is significantly more effort than just deploying all 3 using Riff-Raff so I don't plan to tackle that now. ↩