Pre-Scala 2.13: Fix JavaConversions warnings with scala-collection-compat
#526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtyley
added
the
Scala 2.13
rtyley
force-pushed
the
pre-scala-2.13-fix-JavaConversions-warnings
branch
from
d8978bc to
341e2ab
Compare
…ompat` This codebase was using `scala.collection.JavaConversions._`, which has been deprecated since Scala 2.12. Rather than update to Scala 2.12 syntax, and then later to Scala 2.13 syntax, here we use the https://github.com/scala/scala-collection-compat library to allow us to use Scala 2.13 syntax immediately. The scala-collection-compat library comes with a choice of ScalaFix migrations to automate this update: https://github.com/scala/scala-collection-compat?tab=readme-ov-file#migration-rules ...but they didn't work well for us (introduced a lot of `.iterator` calls on `Iterable`s, for some reason) so we made these changes manually.
rtyley
force-pushed
the
pre-scala-2.13-fix-JavaConversions-warnings
branch
from
341e2ab to
70aea35
Compare
JamieB-gu
approved these changes
Sep 10, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This codebase was using
scala.collection.JavaConversions._, which has been deprecated since Scala 2.12. Rather than update to Scala 2.12 syntax, and then later to Scala 2.13 syntax, here we use thescala-collection-compatlibrary to allow us to use Scala 2.13 syntax immediately.The scala-collection-compat library comes with a choice of ScalaFix migrations to automate this update:
https://github.com/scala/scala-collection-compat?tab=readme-ov-file#migration-rules
...but they didn't work well for us (introduced a lot of
.iteratorcalls onIterables, for some reason) so we made these changes manually.