Fix for missing sbt by using new guardian/setup-scala action #545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fweddi
approved these changes
Dec 20, 2024
|
Seen on PROD (merged by @davidfurey 7 minutes and 24 seconds ago) Please check your changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the new GitHub Action
guardian/setup-scalato cope withsbtbeing removed from the latest Ubuntu images we use for CI. This composite action combinessetup-javaandsetup-sbtwith good defaults for the Guardian.Version of Java used by CI now specified by
.tool-versionsfileNote that
guardian/setup-scalarequires that projects specify their Java version with anasdf-formatted.tool-versionsfile - we didn't have to add one with this PR, as it was already presentBased on guardian/etag-caching#60