Only use Prout on endpoints without heavy caching #466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Of these two endpoints: * https://manager.typerighter.gutools.co.uk/healthcheck - goes direct to ELB * https://checker.typerighter.gutools.co.uk/healthcheck - is behind Cloudfront, and seems to have 1-hour cache time ...because of the long cache time on https://checker.typerighter.gutools.co.uk/healthcheck, I think it's going to be too confusing to point Prout at it? I think if Prout was making a POST request to checker.typerighter.gutools.co.uk, it would presumably get a fresh response from the cache, but it would probably also need to authenticate, for which in Prout there's no mechanism available at the moment.
jonathonherbert
deleted the
only-use-prout-on-endpoints-without-heavy-caching
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following on from #465, of these two checkpoint endpoints:
...because of the long cache time on Checker, I think it's going to be too confusing to point Prout at it?
https://prout-bot.herokuapp.com/view/guardian/typerighter
I think if Prout was making a POST request to checker.typerighter.gutools.co.uk, it would presumably get a fresh response from the cache, but it would probably also need to authenticate, for which in Prout there's no mechanism available at the moment.