Add similarity ordering to rule search #467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathonherbert
force-pushed
the
jsh/add-similarity-to-search
branch
from
bff5bdc to
bfdc202
Compare
rhystmills
approved these changes
Apr 8, 2024
prout-bot
added
Pending-on-Checker
Pending-on-Rule Manager
Seen-on-Rule Manager
and removed
Pending-on-Rule Manager
labels
|
Seen on Rule Manager (merged by @jonathonherbert 9 minutes and 34 seconds ago) Please check your changes! |
|
Overdue on Checker (merged by @jonathonherbert 15 minutes and 3 seconds ago) What's gone wrong? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
I was searching for a dictionary rule, and realised that Typerighter's rule search is not very good.
Part of the reason is that we use a trigram index for comparing words, but do not order by similarity to the search term. This PR adds that ordering, so the results most similar to the search term are surfaced first.
How to test