Resolve critical vulnerability in helper script #486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y maintained and has a critical vulnerability. Also adds some more type information and a script to check that the types are valid.
dblatcher
approved these changes
Dec 6, 2024
prout-bot
added
Pending-on-Checker
Pending-on-Rule Manager
Seen-on-Rule Manager
and removed
Pending-on-Rule Manager
labels
|
Seen on Rule Manager (merged by @davidfurey 9 minutes and 30 seconds ago) Please check your changes! |
|
Overdue on Checker (merged by @davidfurey 15 minutes and 3 seconds ago) What's gone wrong? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Switch from libxml2js to libxml2-wasm. libxml2js is no longer actively maintained and has a critical vulnerability.
Also adds some more type information and a script to check that the types are valid.
How to test
yarn check-typesto show that Typescript is happynode compare-rule-xml.js fixtures/example-rules-old.xml fixtures/example-rules-new.xml fixtures/example-rule-ids.txtto see that script still runs.