Upgrade to panda v7 #490
Merged
Upgrade to panda v7 #490
+6
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidfurey
approved these changes
Jan 16, 2025
prout-bot
added
Pending-on-Checker
Pending-on-Rule Manager
Seen-on-Rule Manager
and removed
Pending-on-Rule Manager
labels
|
Seen on Rule Manager (merged by @waisingyiu 10 minutes and 34 seconds ago) Please check your changes! |
|
Overdue on Checker (merged by @waisingyiu 15 minutes and 3 seconds ago) What's gone wrong? |
This is a bug in our CDN configuration: #468, which needs some attention, aims to fix. So there's no action here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
This pull request upgrades Pan-domain-auth to v7 which supports key rotation.
I follow the guidance from guardian/pan-domain-authentication#160 to make the following changes -
PanDomainAuthSettingsRefresherinstance using theapplyof the companion object withs3BucketLoader, as recommended by the library.I've also replaced the
setup-javaaction with oursetup-scalaaction in the CI github action to fix the build.How to test
The changes were deployed to
CODEand tested in the following ways:When I accessed the
Typerighterwithout sign-in, we were redirected to Google login page and, upon sign-in, toTyperigher. I could accessTyperighterthen. I could also access Composer and Fronts tools without signing in again.When I signed in via Fronts tools first, I could access
Typerighterwithout signing in again.