Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign of CM Editor #3845

Merged
merged 6 commits into from
Nov 24, 2024
Merged

Redesign of CM Editor #3845

merged 6 commits into from
Nov 24, 2024

Conversation

tig
Copy link
Collaborator

@tig tig commented Nov 23, 2024

Fixes

  • Changes Configuration Editor to use TabView insetead of TileView.
  • Adds support for ConfigurationManager.RuntimeConfig

@tig tig marked this pull request as ready for review November 23, 2024 22:31
@tig tig requested a review from BDisp November 23, 2024 22:31
Copy link
Collaborator

@BDisp BDisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding the location to the setting scope it's a good solution. Very good decision of take TabView to edit configuration files leveraging all the screen space to edit them. Very good work. Thanks.

@tig tig merged commit 828d0fd into gui-cs:v2_develop Nov 24, 2024
4 checks passed
@BDisp
Copy link
Collaborator

BDisp commented Nov 24, 2024

@tig it's a little harder to read readonly text.

image

@tig
Copy link
Collaborator Author

tig commented Nov 24, 2024

@tig it's a little harder to read readonly text.

image

Yes, I agree.

This needs to be fixed in

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants