Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #3893 foreach runes bug with unicode surrogate pairs #3894

Merged
merged 2 commits into from
Jan 12, 2025

Conversation

tznind
Copy link
Collaborator

@tznind tznind commented Jan 12, 2025

Fixes

Pull Request checklist:

  • I've named my PR in the form of "Fixes #issue. Terse description."
  • My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
  • My code follows the Terminal.Gui library design guidelines
  • I ran dotnet test before commit
  • I have made corresponding changes to the API documentation (using /// style comments)
  • My changes generate no new warnings
  • I have checked my code and corrected any poor grammar or misspellings
  • I conducted basic QA to assure all features are working

@tznind tznind requested a review from tig as a code owner January 12, 2025 12:10
@tznind tznind changed the title Fix foreach runes bug with unicode surrogate pairs Fixes #3893 foreach runes bug with unicode surrogate pairs Jan 12, 2025
@tznind
Copy link
Collaborator Author

tznind commented Jan 12, 2025

I guess Label is probably not supposed to exercise this code too. it means first underscore disappears - but at least this PR fixes crash!

@tig tig merged commit 81ad695 into gui-cs:v2_develop Jan 12, 2025
4 checks passed
@tznind tznind deleted the 3893_fixUnderscoreMinus branch January 12, 2025 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Underscore breaks Label Draw when it contains certain unicode characters that do not map to Rune
2 participants