Change association behavior to return nils if records cannot be found #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamadalek
approved these changes
May 17, 2024
| @@ -335,5 +335,15 @@ def test_groups_are_preserved_to_association_components | |||
| assert_equal({}, op.without_info_params) | |||
| end | |||
|
|
|||
| def test_find_by_is_used_if_raise_on_miss_is_false | |||
There was a problem hiding this comment.
do we have coverage of the opposite? i looked quick and didn't see anything ad-hoc
mainly to make sure that this change (or future) don't break that behavior
There was a problem hiding this comment.
There are other tests in here that use set expectations on find_by!() usage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.