Skip to content

Commit

Permalink
Precompile fomantic-ui files (go-gitea#13332)
Browse files Browse the repository at this point in the history
We rarely change fomantic-ui or its configuration so it's kind of a
waste to have it rebuild on every CI run. These changes remove the
fomantic files from the build and instead add the relevant output files
to the git index, which should shave of 2-3 minutes on every CI run.

`make fomantic` should still work and should be ran whenever fomantic is
updated or its configuration is changed.

Co-authored-by: techknowlogick <[email protected]>
  • Loading branch information
silverwind and techknowlogick authored Oct 27, 2020
1 parent 7dfb2fc commit 946bbbe
Show file tree
Hide file tree
Showing 6 changed files with 62,672 additions and 4 deletions.
12 changes: 11 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,17 @@ coverage.all
/public/css
/public/fonts
/public/img/webpack
/web_src/fomantic/build
/web_src/fomantic/build/*
!/web_src/fomantic/build/semantic.js
!/web_src/fomantic/build/semantic.css
!/web_src/fomantic/build/themes
/web_src/fomantic/build/themes/*
!/web_src/fomantic/build/themes/default
/web_src/fomantic/build/themes/default/assets/*
!/web_src/fomantic/build/themes/default/assets/fonts
/web_src/fomantic/build/themes/default/assets/fonts/*
!/web_src/fomantic/build/themes/default/assets/fonts/icons.woff2
!/web_src/fomantic/build/themes/default/assets/fonts/outline-icons.woff2
/VERSION
/.air

Expand Down
6 changes: 3 additions & 3 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,7 @@ node-check:

.PHONY: clean-all
clean-all: clean
rm -rf $(WEBPACK_DEST_ENTRIES) $(FOMANTIC_DEST_DIR)
rm -rf $(WEBPACK_DEST_ENTRIES)

.PHONY: clean
clean:
Expand Down Expand Up @@ -323,7 +323,7 @@ watch:
bash tools/watch.sh

.PHONY: watch-frontend
watch-frontend: node-check $(FOMANTIC_DEST) node_modules
watch-frontend: node-check node_modules
rm -rf $(WEBPACK_DEST_ENTRIES)
NODE_ENV=development npx webpack --hide-modules --display-entrypoints=false --watch --progress

Expand Down Expand Up @@ -541,7 +541,7 @@ install: $(wildcard *.go)
build: frontend backend

.PHONY: frontend
frontend: node-check $(FOMANTIC_DEST) $(WEBPACK_DEST)
frontend: node-check $(WEBPACK_DEST)

.PHONY: backend
backend: go-check generate $(EXECUTABLE)
Expand Down
Loading

0 comments on commit 946bbbe

Please sign in to comment.