-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented search_in_response_to #1676
base: master
Are you sure you want to change the base?
Conversation
Implemented the concept of `search_in_response_to` in `learn_reposne`. If `previous_statement` is an instance of `chatterbot.conversation.Statement`, learning will save `previous_statement.search_text` as `statement.search_in_response_to`.
Logger statement was removed in the earlier commit by mistake
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added logger statement, as pointed by @gunthercox
@gunthercox anything here expected of me? |
@iamhssingh Sorry about the wait, these changes look good and I'll merge them in shortly. |
Actually, I just realized that this is missing unit tests. Is there any additional tests cases that can be added to cover these changes? |
@gunthercox Sure. I see this change has yet not been implemented. I will write the test cases & update the commit. I am sorry for being this late, bad times! |
@gunthercox Are you using Here's the expected behavior of this logic adapter:
|
* Fixed doc string * Restructured example to provide more beautiful example
The test cases that are already there takes care of current implementation as well. |
Implemented the concept of
search_in_response_to
inlearn_reposne
. Ifprevious_statement
is an instance ofchatterbot.conversation.Statement
, learning will saveprevious_statement.search_text
asstatement.search_in_response_to
.