Minor restructuring for response creation #1810
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background Context
In my own use of this library, I structured it such that individual
LogicAdapter
s are able to specify certain response styles, based on certain criteria. I do this by attaching additional information through theStatement
object, which is passed around in a variety of functions.Issue
generate_response
in theChatBot
class overrides the resultingStatement
object.Proposed Fix
By breaking it up into a separate function, we keep the original function cleaner, as well as allows customization of the flow through polymorphism. Otherwise, we would need to duplicate a large chunk of code (the original
generate_response
), and this would lead to future maintenance problems down the road.