Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update languages.py #2094

Closed
wants to merge 1 commit into from
Closed

Update languages.py #2094

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion chatterbot/languages.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -581,7 +581,7 @@ class ELX:


class ENG:
ISO_639_1 = 'en'
ISO_639_1 = 'en_core_web_sm'
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

languages.py is a collection of classes representing language codes, this line should continue to be the ISO_639 language code. I've made a change in #2389 that I believe will resolve this with a bit more flexibility for different languages:
https://github.com/gunthercox/ChatterBot/pull/2389/files#diff-a30358b68e779ddc228075ea1421f86901a2f3818447a4d905624706b43f42c7R30

ISO_639 = 'eng'
ENGLISH_NAME = 'English'

Expand Down