Feature flag to disable dynamic build loading in experimental settings.

gwdevhub · Apr 22, 2021 · bc66ca9 · bc66ca9
1 parent 524cd21
commit bc66ca9
Show file tree

Hide file tree

Showing 5 changed files with 16 additions and 1 deletion.
diff --git a/Daybreak/Configuration/ExperimentalFeatures.cs b/Daybreak/Configuration/ExperimentalFeatures.cs
@@ -8,5 +8,7 @@ public sealed class ExperimentalFeatures
         public bool MultiLaunchSupport { get; set; }
         [JsonProperty("ToolboxAutoLaunchDelay")]
         public int ToolboxAutoLaunchDelay { get; set; } = 5000;
+        [JsonProperty("DynamicBuildLoading")]
+        public bool DynamicBuildLoading { get; set; } = true;
     }
 }
diff --git a/Daybreak/Controls/ChromiumBrowserWrapper.xaml.cs b/Daybreak/Controls/ChromiumBrowserWrapper.xaml.cs
@@ -138,6 +138,7 @@ private async Task InitializeBrowser()
             {
                 await this.WebBrowser.EnsureCoreWebView2Async(this.coreWebView2Environment);
                 this.AddressBarReadonly = this.configurationManager.GetConfiguration().AddressBarReadonly;
+                this.CanDownloadBuild = this.configurationManager.GetConfiguration().ExperimentalFeatures.DynamicBuildLoading;
                 this.WebBrowser.CoreWebView2.NewWindowRequested += (browser, args) => args.Handled = true;
                 this.WebBrowser.NavigationStarting += (browser, args) =>
                 {

diff --git a/Daybreak/Daybreak.csproj b/Daybreak/Daybreak.csproj
@@ -9,7 +9,7 @@
     <CopyLocalLockFileAssemblies>false</CopyLocalLockFileAssemblies>
     <LangVersion>preview</LangVersion>
     <ApplicationIcon>Daybreak.ico</ApplicationIcon>
-    <Version>0.7.0</Version>
+    <Version>0.7.1</Version>
     <ApplicationManifest>app.manifest</ApplicationManifest>
   </PropertyGroup>
 

diff --git a/Daybreak/Views/ExperimentalSettingsView.xaml b/Daybreak/Views/ExperimentalSettingsView.xaml
@@ -90,13 +90,16 @@
             <StackPanel>
                 <TextBlock Text="Multi-launch support" Foreground="White" FontSize="22" VerticalAlignment="Center" Margin="0, 0, 15, 0" Height="30"></TextBlock>
                 <TextBlock Text="GWToolbox startup delay (in ms)" Foreground="White" FontSize="22" VerticalAlignment="Center" Margin="0, 0, 15, 0" Height="30"></TextBlock>
+                <TextBlock Text="Detect build templates (in browser)" Foreground="White" FontSize="22" VerticalAlignment="Center" Margin="0, 0, 15, 0" Height="30"></TextBlock>
             </StackPanel>
             <StackPanel Grid.Column="1">
                 <ToggleButton IsChecked="{Binding ElementName=_this, Path=MultiLaunch, Mode=TwoWay}" Style="{StaticResource AnimatedSwitch}"
                               Height="30" Width="60"></ToggleButton>
                 <TextBox Background="Transparent" Foreground="White" FontSize="16" Height="30" 
                          PreviewTextInput="TextBox_AllowNumbersOnly" Text="{Binding ElementName=_this, Path=GWToolboxLaunchDelay, Mode=TwoWay, UpdateSourceTrigger=PropertyChanged}"
                          CommandManager.PreviewCanExecute="TextBox_DisallowPaste"></TextBox>
+                <ToggleButton IsChecked="{Binding ElementName=_this, Path=DynamicBuildLoading, Mode=TwoWay}" Style="{StaticResource AnimatedSwitch}"
+                              Height="30" Width="60"></ToggleButton>
             </StackPanel>
         </Grid>
     </Grid>

diff --git a/Daybreak/Views/ExperimentalSettingsView.xaml.cs b/Daybreak/Views/ExperimentalSettingsView.xaml.cs
@@ -19,6 +19,8 @@ public partial class ExperimentalSettingsView : UserControl
             DependencyPropertyExtensions.Register<ExperimentalSettingsView, bool>(nameof(MultiLaunch));
         public static readonly DependencyProperty GWToolboxLaunchDelayProperty =
             DependencyPropertyExtensions.Register<ExperimentalSettingsView, string>(nameof(GWToolboxLaunchDelay));
+        public static readonly DependencyProperty DynamicBuildLoadingProperty =
+            DependencyPropertyExtensions.Register<ExperimentalSettingsView, bool>(nameof(DynamicBuildLoading));
 
         private readonly IViewManager viewManager;
         private readonly IConfigurationManager configurationManager;
@@ -33,6 +35,11 @@ public string GWToolboxLaunchDelay
             get => this.GetTypedValue<string>(GWToolboxLaunchDelayProperty);
             set => this.SetValue(GWToolboxLaunchDelayProperty, value);
         }
+        public bool DynamicBuildLoading
+        {
+            get => this.GetTypedValue<bool>(DynamicBuildLoadingProperty);
+            set => this.SetValue(DynamicBuildLoadingProperty, value);
+        }
 
         public ExperimentalSettingsView(
             IViewManager viewManager,
@@ -49,12 +56,14 @@ private void LoadExperimentalSettings()
             var config = this.configurationManager.GetConfiguration();
             this.MultiLaunch = config.ExperimentalFeatures.MultiLaunchSupport;
             this.GWToolboxLaunchDelay = config.ExperimentalFeatures.ToolboxAutoLaunchDelay.ToString();
+            this.DynamicBuildLoading = config.ExperimentalFeatures.DynamicBuildLoading;
         }
 
         private void SaveExperimentalSettings()
         {
             var config = this.configurationManager.GetConfiguration();
             config.ExperimentalFeatures.MultiLaunchSupport = this.MultiLaunch;
+            config.ExperimentalFeatures.DynamicBuildLoading = this.DynamicBuildLoading;
             if (int.TryParse(this.GWToolboxLaunchDelay, out var gwToolboxLaunchDelay))
             {
                 config.ExperimentalFeatures.ToolboxAutoLaunchDelay = gwToolboxLaunchDelay;