Use http constants as function arguments

Signed-off-by: Zechun Chen <[email protected]>
gy95 · Feb 13, 2023 · 52f8b2e · 52f8b2e
1 parent 1df335f
commit 52f8b2e
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 6 deletions.
diff --git a/edge/pkg/edgehub/certificate/certmanager.go b/edge/pkg/edgehub/certificate/certmanager.go
@@ -293,7 +293,7 @@ func (cm *CertManager) GetEdgeCert(url string, capem []byte, cert tls.Certificat
 	if err != nil {
 		return nil, nil, err
 	}
-	if res.StatusCode != 200 {
+	if res.StatusCode != nethttp.StatusOK {
 		return nil, nil, fmt.Errorf(string(content))
 	}
 

diff --git a/edge/pkg/servicebus/util/httpclient_test.go b/edge/pkg/servicebus/util/httpclient_test.go
@@ -28,7 +28,7 @@ func TestURLClient_HTTPDo(t *testing.T) {
 func getMockServer(t *testing.T) *httptest.Server {
 	ts := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
 		switch r.Method {
-		case "GET":
+		case http.MethodGet:
 			if r.URL.EscapedPath() != "/test" {
 				t.Errorf("path error: %s", r.URL.EscapedPath())
 				w.WriteHeader(http.StatusNotFound)

diff --git a/edge/test/cloudhub/stub.go b/edge/test/cloudhub/stub.go
@@ -92,10 +92,10 @@ func (tm *stubCloudHub) podHandler(w http.ResponseWriter, req *http.Request) {
 		}
 		var msgReq *model.Message
 		switch req.Method {
-		case "POST":
+		case http.MethodPost:
 			msgReq = model.NewMessage("").BuildRouter("edgecontroller", "resource",
 				"node/fake_node_id/pod/"+string(pod.UID), model.InsertOperation).FillBody(pod)
-		case "DELETE":
+		case http.MethodDelete:
 			msgReq = model.NewMessage("").BuildRouter("edgecontroller", "resource",
 				"node/fake_node_id/pod/"+string(pod.UID), model.DeleteOperation).FillBody(pod)
 		}

diff --git a/edgesite/cmd/edgesite-server/app/server.go b/edgesite/cmd/edgesite-server/app/server.go
@@ -353,11 +353,11 @@ func (p *Proxy) runHealthServer(o *options.ProxyRunOptions, server *server.Proxy
 	readinessHandler := http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
 		ready, msg := server.Readiness.Ready()
 		if ready {
-			w.WriteHeader(200)
+			w.WriteHeader(http.StatusOK)
 			fmt.Fprintf(w, "ok")
 			return
 		}
-		w.WriteHeader(500)
+		w.WriteHeader(http.StatusInternalServerError)
 		fmt.Fprintf(w, msg)
 	})