Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: ⚡️ Fetch data concurrently in async mode #117

Merged
merged 1 commit into from
Jan 14, 2025
Merged

Conversation

zoido
Copy link
Collaborator

@zoido zoido commented Jan 10, 2025

Discovery requires multiple requests to get all of the data. Asyncio allows us to send all requets concurently and the await the results.

This should improve latency of the async variant

Discovery requires multiple requests to get all of the data. Asyncio allows us to send all requets concurently and the await the results.

This should improve latency of the async variant
@zoido zoido self-assigned this Jan 10, 2025
@zoido zoido marked this pull request as ready for review January 10, 2025 08:04
@zoido zoido requested a review from johnygomez January 10, 2025 08:05
Copy link
Member

@johnygomez johnygomez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zoido zoido added this pull request to the merge queue Jan 14, 2025
Merged via the queue into main with commit 2a8f8ea Jan 14, 2025
19 checks passed
@zoido zoido deleted the lp/fetch-in-par branch January 14, 2025 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants