Implement suspend and resume endpoints of supervisor API #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vzayts
requested review from
vzayts,
zoido and
codyharris-h2o-ai
as code owners
|
Opening this one for review. |
zoido
reviewed
Dec 11, 2023
supervisor.go
Outdated
Comment on lines
125
to
128
| var result OutputIngestionSpec | ||
| if err != nil { | ||
| return result, err | ||
| } |
There was a problem hiding this comment.
Style/Optional:
- Usually, error handling should come right after the call that returns error.
- I'd say it's usually safer to return explicit zero value in err branches.
(applies to Resume as well)
Comment on lines
+153
to
155
| type QueryGranularity struct { | ||
| Type string `json:"type,omitempty"` | ||
| } |
There was a problem hiding this comment.
Suggested change
| type QueryGranularity struct { | |
| Type string `json:"type,omitempty"` | |
| } | |
| type QueryGranularity struct { | |
| Type string `json:"type,omitempty"` | |
| } |
And add a comment please.
tomasz-h2o
commented
Dec 11, 2023
zoido
approved these changes
Dec 12, 2023
tomasz-h2o
commented
Dec 12, 2023
| var result SupervisorStatus | ||
| r, err := s.client.NewRequest("GET", applySupervisorId(supervisorStatusEndpoint, supervisorId), nil) |
There was a problem hiding this comment.
nit: please consider using http.MethodGet
Co-authored-by: Luboš Pokorný <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is on hold as a work of extended deduplication.
Addresses https://github.com/h2oai/telemetry/issues/167