[PUBDEV-5804] Return variable importances as named tuples instead of regular tuples #2705
+44
−41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wendy is on vacation. Erin, would you want to review/merge, or wait for Wendy's return? |
wendycwong
approved these changes
Aug 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per discussion #python-client, we want
model.varimp()to return named tuples instead of simple tuples.The
DimReductionclass contained method.varimp()which was exactly the same as inBaseModelwith the exception of the name of its json property. I merged this method with the base -- this should work assumingDimReductionhas the same field names in its.varimp()output. If not, then we'd better be explicit about it.As far as I can see we currently have very little test coverage of variable importance -- perhaps more tests can be added?