Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pubdev-3451: add quiet argument to init #3032

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

fennovj
Copy link

@fennovj fennovj commented Nov 13, 2018

Hello h2o people,

Jira here: https://0xdata.atlassian.net/browse/PUBDEV-3451

This is my first contribution to h2o, so if I did anything wrong, just point it out. I hope I followed all the guidelines.

This is a new feature, that adds an option to the 'h2o.init' function, to surpress output. As mentioned in the Jira, this has advantages for R, because the outputs interfere with knitr documents, making it hard to use h2o in latex. Furthermore, the output can interfere with certain unit test or build pipelines.
The progress bars can be disabled with "h2o.no_progress()". It would be nice if the startup connection messages could be disabled too.

The option is implemented slightly differently for R and Python. In Python, 'verbose' is set to False, meaning no connection messages are printed at all, including when shutting down, etcetera. In R, there is no such verbose mode, so only the messages during init are hidden, to match the Jira ticket.

@michalkurka michalkurka self-requested a review November 13, 2018 17:03
@michalkurka michalkurka requested a review from ledell December 20, 2018 00:58
@michalkurka
Copy link
Contributor

@fvermeij thank you for your contribution. It is very appreciated.

At a first glance, things look good!

@ledell was the requester of this change. Erin, can you please review?

@michalkurka
Copy link
Contributor

Mr. Jenkins, please test!

@ledell
Copy link
Contributor

ledell commented Dec 21, 2018

Thanks, I will review this soon! Very nice idea, I think people have complained about this before.

@swt2c
Copy link

swt2c commented May 30, 2019

@fvermeij any chance you could resolve the merge conflicts? I would love to see this change implemented. When running h2o from cron, I don't want to see any output unless there is a problem.

…et_argument_to_init

Conflicts:
	h2o-py/h2o/h2o.py
	h2o-r/h2o-package/R/connection.R
@fennovj
Copy link
Author

fennovj commented May 31, 2019

@fvermeij any chance you could resolve the merge conflicts? I would love to see this change implemented. When running h2o from cron, I don't want to see any output unless there is a problem.

Yes I fixed them :) I agree this would be a useful extra option for h2o, even though this PR has been inactive for a while.

@bscan
Copy link

bscan commented Nov 2, 2019

Hey, I'd love to see this implemented too. I commented this on the Jira ticket as well, but an important use case is Kaggle Notebooks. They are becoming popular ways to show others how to use an algorithm or software package. However, when using H2O for simple examples, much of the output consists of cluster diagnostics irrelevant to the algorithm itself and often poorly formatted. This gives the impression to novices that H2O is "heavy" or complicated when in reality it's user friendly due to things like automatic categorical feature encoding, lambda_search, and AutoML.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants