Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add reveal button to password textbox #1977 #2198

Merged
merged 5 commits into from
Nov 21, 2023
Merged

Conversation

marek-mihok
Copy link
Contributor

@marek-mihok marek-mihok commented Nov 20, 2023

The PR fulfills these requirements: (check all the apply)

  • It's submitted to the main branch.
  • When resolving a specific issue, it's referenced in the PR's title (e.g. feat: Add a button #xxx, where "xxx" is the issue number).
  • When resolving a specific issue, the PR description includes Closes #xxx, where "xxx" is the issue number.
  • If changes were made to ui folder, unit tests (make test) still pass.
  • New/updated tests are included

Screen.Recording.2023-11-20.at.12.45.58.mov

Updated API description for password prop:

  /** True if the text box should hide text content unless it is revealed by the eye icon. */
  password?: B

image

Closes #1977

@marek-mihok marek-mihok marked this pull request as ready for review November 20, 2023 12:01
Copy link
Collaborator

@mturoci mturoci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mturoci mturoci merged commit 9c05467 into main Nov 21, 2023
2 checks passed
@mturoci mturoci deleted the feat/issue-1977 branch November 21, 2023 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow show/hide functionality for passwords in ui.textbox()
2 participants