Sudoku generator

.clang-tidy

@@ -0,0 +1,45 @@
+---
+Checks:          'clang-diagnostic-*,clang-analyzer-*'
+WarningsAsErrors: '--checks=bugprone-*,performance-*,readability-*,portability-*,modernize-*,clang-analyzer-cplusplus-*,clang-analyzer-*,cppcoreguidelines-*'
+HeaderFilterRegex: ''
+AnalyzeTemporaryDtors: false
+FormatStyle:     none
+User:            h3nnn4n
+CheckOptions:
+  - key:             cert-dcl16-c.NewSuffixes
+    value:           'L;LL;LU;LLU'
+  - key:             cert-oop54-cpp.WarnOnlyIfThisHasSuspiciousField
+    value:           '0'
+  - key:             cert-str34-c.DiagnoseSignedUnsignedCharComparisons
+    value:           '0'
+  - key:             cppcoreguidelines-explicit-virtual-functions.IgnoreDestructors
+    value:           '1'
+  - key:             cppcoreguidelines-non-private-member-variables-in-classes.IgnoreClassesWithAllMemberVariablesBeingPublic
+    value:           '1'
+  - key:             google-readability-braces-around-statements.ShortStatementLines
+    value:           '1'
+  - key:             google-readability-function-size.StatementThreshold
+    value:           '800'
+  - key:             google-readability-namespace-comments.ShortNamespaceLines
+    value:           '10'
+  - key:             google-readability-namespace-comments.SpacesBeforeComments
+    value:           '2'
+  - key:             llvm-else-after-return.WarnOnConditionVariables
+    value:           '0'
+  - key:             llvm-else-after-return.WarnOnUnfixable
+    value:           '0'
+  - key:             llvm-qualified-auto.AddConstToQualified
+    value:           '0'
+  - key:             modernize-loop-convert.MaxCopySize
+    value:           '16'
+  - key:             modernize-loop-convert.MinConfidence
+    value:           reasonable
+  - key:             modernize-loop-convert.NamingStyle
+    value:           CamelCase
+  - key:             modernize-pass-by-value.IncludeStyle
+    value:           llvm
+  - key:             modernize-replace-auto-ptr.IncludeStyle
+    value:           llvm
+  - key:             modernize-use-nullptr.NullMacros
+    value:           'NULL'
+...

.github/workflows/clang-tidy-check.yml

@@ -19,6 +19,9 @@ jobs:
           sudo apt-get -y -qq install clang-tidy cmake jq clang cppcheck
           python -m pip install scan-build
 
+      - name: Update Path
+        run: echo "$HOME/.local/bin" >> $GITHUB_PATH
+
       - name: Update compile database
         run: |
           make clean

.github/workflows/cppcheck.yml

@@ -19,10 +19,13 @@ jobs:
           sudo apt-get -y -qq install clang-tidy cmake jq clang cppcheck
           python -m pip install scan-build
 
+      - name: Update Path
+        run: echo "$HOME/.local/bin" >> $GITHUB_PATH
+
       - name: Update compile database
         run: |
           make clean
           intercept-build make
 
       - name: run cppcheck
-        run: cppcheck --enable=all --std=c11 --language=c --error-exitcode=1  src/*.c
+        run: cppcheck --enable=all --std=c11 --language=c --error-exitcode=1 src/*.c src/**/*.c

.github/workflows/cpplint.yml

@@ -17,6 +17,9 @@ jobs:
           python3 -m pip install cpplint
           python3 -m pip install scan-build
 
+      - name: Update Path
+        run: echo "$HOME/.local/bin" >> $GITHUB_PATH
+
       - name: Update compile database
         run: |
           make clean

.github/workflows/heap-check.yml

@@ -19,13 +19,25 @@ jobs:
 
       - name: Build
         run: make gperftools
+        env:
+          CFLAGS: -DGRID_SIZE=2 -DN_GRIDS=2
 
       - name: Detect Leaks on single solution
-        run: ./dancing-links --single-solution --quited < samples/5x8_2xAll_freePieces.dat
+        run: ./dancing-links --single-solution --quiet < samples/5x8_2xAll_freePieces.dat
         env:
           HEAPCHECK: normal
 
       - name: Detect Leaks on multiple solutions
-        run: ./dancing-links --multiple-solutions --quited < samples/5x5_5_pentoI.dat
+        run: ./dancing-links --multiple-solutions --quiet < samples/5x5_5_pentoI.dat
+        env:
+          HEAPCHECK: normal
+
+      - name: Detect Leaks on generate coverset from file
+        run: ./dancing-links --sudoku-gen samples/sudoku/sudoku_2.in
+        env:
+          HEAPCHECK: normal
+
+      - name: Detect Leaks on generate coverset from str
+        run: ./dancing-links --sudoku-gen 0100002030000004
         env:
           HEAPCHECK: normal

.github/workflows/run.yml

@@ -5,6 +5,7 @@ on: push
 jobs:
   run-benchmarks:
     runs-on: ${{ matrix.os }}
+    timeout-minutes: 5
 
     strategy:
       matrix:
@@ -16,8 +17,10 @@ jobs:
           fetch-depth: 1
           submodules: true
 
-      - name: Build
-        run: make
+      - name: Build (2x2)
+        run: make rebuild
+        env:
+          CFLAGS: -DGRID_SIZE=2 -DN_GRIDS=2
 
       - name: Run simple problem, default args
         run: ./dancing-links --multiple-solutions < samples/5x5_5_pentoI.dat
@@ -27,3 +30,20 @@ jobs:
 
       - name: Run complex problem, single solution
         run: ./dancing-links --single-solution < samples/5x8_2xAll_freePieces.dat
+
+      - name: Run sudoku gen and solve
+        run: |
+          ./dancing-links --sudoku-gen samples/sudoku/sudoku_2.in > sudoku_test.dat
+          ./dancing-links --single-solution < sudoku_test.dat
+          ./dancing-links --sudoku-parse output.dat
+
+      - name: Build (3x3)
+        run: make rebuild
+        env:
+          CFLAGS: -DGRID_SIZE=3 -DN_GRIDS=3
+
+      - name: Run sudoku gen and solve
+        run: |
+          ./dancing-links --sudoku-gen samples/sudoku/sudoku.in > sudoku_test.dat
+          ./dancing-links --single-solution < sudoku_test.dat
+          ./dancing-links --sudoku-parse output.dat

.github/workflows/valgrind.yml

@@ -0,0 +1,30 @@
+name: valgrind
+
+on: push
+
+jobs:
+  build:
+    runs-on: ubuntu-latest
+
+    steps:
+      - uses: actions/checkout@master
+        with:
+          fetch-depth: 1
+          submodules: true
+
+      - name: Install deps
+        run: |
+          sudo apt-get update
+          sudo apt-get -y -qq install valgrind
+
+      - name: Build
+        run: make callgrind
+
+      - name: Run valgrind on sudoku gen
+        run: ./dancing-links --sudoku-gen samples/sudoku/sudoku_2.in > sudoku_test.dat
+
+      - name: Run valgrind on sudoku solve
+        run: ./dancing-links --single-solution < sudoku_test.dat
+
+      - name: Run valgrind on sudoku parse
+        run: ./dancing-links --sudoku-parse output.dat

.gitignore

@@ -40,3 +40,7 @@ build
 
 # Cache files
 .cache # used by clang
+*.idx  # used by clang
+
+# perf files
+gmon.out

.pre-commit-config.yaml

@@ -12,19 +12,15 @@ repos:
     hooks:
     -   id: clang-format
 
-repos:
 -   repo: https://github.com/pocc/pre-commit-hooks
     rev: v1.1.1
     hooks:
     -   id: clang-tidy
-        args:
-        - -checks=clang-diagnostic-return-type
+        args: ['--warnings-as-errors', '--checks=bugprone-*,performance-*,readability-*,portability-*,modernize-*,clang-analyzer-cplusplus-*,clang-analyzer-*,cppcoreguidelines-*']
 
-repos:
 -   repo: https://github.com/bmorcos/pre-commit-hooks-cpp
     rev: 9a5aa38207bf557961110d6a4f7e3a9d352911f9
     hooks:
-    -   id: cpplint
-        args:
-        - --filter=-build/include_subdir,-readability/nolint,-whitespace/line_length,-readability/casting,-build/header_guard
     -   id: cppcheck
+    -   id: cpplint
+        args: ['--filter=-build/include_subdir,-readability/nolint,-whitespace/line_length,-readability/casting,-build/header_guard']

Makefile

@@ -18,7 +18,7 @@ override CFLAGS += -Wall -Wextra -pedantic -std=c11 $(OPTIMIZATION) $(OPTIONS) $
 UNAME_S := $(shell uname -s)
 ifeq ($(UNAME_S),Linux)
   ECHOFLAGS = -e
-  LDFLAGS = -Wl,-Ldeps/Unity/build/
+  UNAME_S = -Wl,-Ldeps/Unity/build/
 endif
 ifeq ($(UNAME_S),Darwin)
   CFLAGS += -Wno-unused-command-line-argument
@@ -27,7 +27,8 @@ endif
 
 CC = gcc
 
-C_FILES := $(wildcard src/*.c)
+C_FILES := $(wildcard src/*.c) \
+           $(wildcard src/**/*.c)
 C_FILES_TEST := $(wildcard test/*.c)
 C_FILES_TEST_DEPS := $(wildcard deps/Unity/src/*.c)