-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Guest application formik context #630 #640
Conversation
…lication_FormikContext_#630
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JpadillaCoding this is looking great! I think this sets a solid foundation to build off of. I made some suggestions for the GuestApplicationButtons
component so let me know what you think.
…lication_FormikContext_#630
This reverts commit 3fc4547. Reverting to last stable version before Gh actions error
…lication_FormikContext_#630
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JpadillaCoding This is looking good Jose. I have a couple suggestions regarding the setting of the initial step. This should be good to go after those changes are made
…lication_FormikContext_#630
…ssary calculations and local storage data request
@erikguntner Requested changes have been made. |
@JpadillaCoding Thanks for getting those changes in! Everything looks good to me. |
Closes #630
What changes did you make?
Rationale behind the changes?
stepToRouteMapping
is used to control which page is rendered. Each page that is added to the route should be added here for the stepper to know where to take the user. The name should match the path name in themain
file.PasswordResetContext
in themain
file as an example of how to add routes in the context wrapper.Testing done for these changes
What did you learn or can share that is new?(optional)
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
Visuals before changes are applied
N/A
Visuals after changes are applied
Screen.Recording.2023-12-05.at.5.50.47.PM.mov