Fix user redirects and tests

[erikguntner]

Closes #645

What changes did you make?

• Removed the resetting of credentials on logout
• Updated the redirect when visiting protected outs from / to /signin
• Removed the /profile path from the protected paths in the e2e tests since it no longer exists
• Made /signout a protected route. I noticed it wasn't protected and therefore wasn't causing a token refresh if they were expired.

Rationale behind the changes?

I made these changes to correctly redirect the user based on 2 cases:

1. When the user logs out they are redirected to /
2. When the user tries to access a protected page. For example, when they aren’t logged in or logged in as a different user role they are redirected to the /signin in page

One issue I ran into was the ProtectedRoute component was redirecting the user after logging out instead of allowing us to choose the path. This was being caused by this line of code in app/src/components/common/AuthenticatedHeader.tsx:

appDispatch(setCredentials({user: null, token: null}))

The ProtectedRoute component relies on the user object to determine whether to navigate the user to /signin or render the necessary components. A change to the user object was causing the component to render<Navigate to="/signin" state={{from: location}} replace />; and override our call to navigate('/'). By removing the state update we can now redirect the user to the home page. However, the user object is still stored in state, but since the credentials are no longer valid the user can't log in or access any protected routes. The user object will also be reset anytime the user revisits the application or a protected endpoint.

Testing done for these changes

• Updated Cypress tests to reflect the proper route redirects. There were also a lot of linter updates that were updated as well.

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied

Visuals after changes are applied

Screen.Recording.2024-01-17.at.12.58.00.PM.mov

[JpadillaCoding]

The intended changes of redirecting the user on logout to / works and the user is also redirected to /signin when they are not logged in and try to access a protected route.

Thanks for the fix Erik!