Only register the telescope service provider if its enabled #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
zach2825
commented
Mar 26, 2024
zach2825
commented
- resolves Disable telescope by default #233 - Disable telescope by default
I compiled and included telescope assets since they are tiny. Also disabled telescope by default. If you want to use it, you can set `TELESCOPE_ENABLED=true` in your .env file
…bug/issue-233/disalbe-telescope-by-default
…bug/issue-233/disalbe-telescope-by-default
…bug/issue-233/disalbe-telescope-by-default
|
@allella This should resolve the composer issue you saw when telescope is not enabled. I only register the telescope provider if its enabled |
allella
approved these changes
Mar 26, 2024
|
@zach2825 this was merged and pulled, but I'm still getting the error on stage. Would the following in config.app be causing the class to load?
|
|
Sorry, I meant to say config/app.php I just patched that file on stage, removing the |
allella
added a commit
to allella/hackgreenville-com
that referenced
this pull request
Mar 27, 2024
…ically register in app/Providers/AppServiceProvider.php if Telescope is enabled in the .env environment variables. Fixes hackgvl#242.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.