Support Luma #341
Merged
Support Luma #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
irby
reviewed
Jul 11, 2024
allella
reviewed
Jul 12, 2024
allella
reviewed
Jul 12, 2024
allella
reviewed
Jul 12, 2024
There was a problem hiding this comment.
Looks like a solid start to get us live and see what the real-world throws at us.
Nice work on finding the public API. It seems like that exposes a bit more than they might want, like the attendees names, so I wouldn't be surprised if they dialed down this calendar URL at some point, but for now it seems more complete and easier to use than the JSON+LD, so let's roll with it.
I tried to poke holes in the venue and online vs offline, but it looks like you covered the variations that I thought to check.
Added a few questions and suggestions in this one.
allella
approved these changes
Jul 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.